Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(drive-abci): skip state transition txs if time limit is reached on prepare_proposal #2041

Merged
merged 5 commits into from
Aug 8, 2024

Conversation

ogabrielides
Copy link
Collaborator

@ogabrielides ogabrielides commented Aug 7, 2024

Issue being fixed or feature implemented

What was done?

  • When a node is preparing a block proposal, it will skip and mark as not executed remaining state transitions txs when a time limit is reached.
  • Added in Abci config the value of the limit with a default value of 8 seconds.

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@ogabrielides ogabrielides changed the title feat(abci): Don't process state transitions if time limit is reached feat(drive-abci): Don't process state transitions if time limit is reached Aug 7, 2024
@ogabrielides ogabrielides changed the title feat(drive-abci): Don't process state transitions if time limit is reached feat(drive-abci): don't process state transitions if time limit is reached Aug 7, 2024
@ogabrielides ogabrielides changed the title feat(drive-abci): don't process state transitions if time limit is reached feat(drive-abci): skip state transition tx if time limit is reached on prepare_proposal Aug 7, 2024
@ogabrielides ogabrielides changed the title feat(drive-abci): skip state transition tx if time limit is reached on prepare_proposal feat(drive-abci): skip state transition txs if time limit is reached on prepare_proposal Aug 7, 2024
@pshenmic
Copy link
Collaborator

pshenmic commented Aug 8, 2024

Does that mean that some of the successful tenderdash transactions could be not written in the drive chain?

@ogabrielides ogabrielides added this to the v1.1 milestone Aug 8, 2024
@QuantumExplorer
Copy link
Member

@pshenmic nope, just that they won't be included into blocks, should not affect you, but it will speed up the network.

@QuantumExplorer
Copy link
Member

merging this in as the CI issues that we see are not associated to this PR.

@QuantumExplorer QuantumExplorer merged commit 6055b33 into v1.1-dev Aug 8, 2024
34 of 37 checks passed
@QuantumExplorer QuantumExplorer deleted the time_limit_txs_prepare_proposal branch August 8, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants