Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashmate): imported node is not starting #2009

Merged
merged 9 commits into from
Jul 29, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Jul 25, 2024

Issue being fixed or feature implemented

After importing Core data a node might not start if indexed was enabled.

What was done?

  • Instruct user to reindex node instead of just starting

How Has This Been Tested?

Running locally

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@thephez
Copy link
Collaborator

thephez commented Jul 25, 2024

Appears to work once the suggested change is made
Screenshot from 2024-07-25 11-53-03

thephez
thephez previously approved these changes Jul 25, 2024
Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partially-tested ACK. This fixed the crash issue from before.

pshenmic
pshenmic previously approved these changes Jul 26, 2024
Copy link
Collaborator

@pshenmic pshenmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@shumkov shumkov dismissed stale reviews from pshenmic and thephez via f8c4a02 July 29, 2024 10:43
@shumkov shumkov merged commit c20d5fd into v1.0-dev Jul 29, 2024
21 checks passed
@shumkov shumkov deleted the fix/dashmate/imported-node-needs-reindex branch July 29, 2024 15:09
@thephez thephez added this to the v1.0.0 milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants