Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(strategy-tests): transfer keys were being disabled #1995

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

pauldelucia
Copy link
Member

Issue being fixed or feature implemented

When we did IdentityUpdate(DisableKeys) transitions in strategies, we were sometimes disabling transfer keys, but we don't want to do that.

What was done?

Prevent IdentityUpdate(DisableKeys) transitions from disabling transfer keys in strategy tests

How Has This Been Tested?

TUI

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov merged commit 69d00fd into v1.0-dev Jul 24, 2024
17 checks passed
@shumkov shumkov deleted the fix/dont-disable-transfer-keys-in-strategies branch July 24, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants