Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform)!: add hyphen to match for contested documents on Dashpay #1982

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

QuantumExplorer
Copy link
Member

Issue being fixed or feature implemented

What was done?

Changed the Dashpay contract to also have a contested document if a hyphen is used.

How Has This Been Tested?

Breaking Changes

Ever so slightly breaking since the Dashpay contract changes.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Copy link
Collaborator

@ogabrielides ogabrielides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@QuantumExplorer QuantumExplorer merged commit d3170b9 into v1.0-dev Jul 22, 2024
71 checks passed
@QuantumExplorer QuantumExplorer deleted the fix/addHyphenToContestedDocuments branch July 22, 2024 14:59
@thephez thephez added this to the v1.0.0 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants