Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(drive): don't use private bound for public trait #1974

Merged
merged 1 commit into from
Jul 17, 2024
Merged

refactor(drive): don't use private bound for public trait #1974

merged 1 commit into from
Jul 17, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Jul 17, 2024

Issue being fixed or feature implemented

Using the private bound PlatformStateV0PrivateMethods for public the PlatformStateV0Methods trait is a bad idea. Not sure how it even compiles.

What was done?

  • Removed the PlatformStateV0PrivateMethods bound from the PlatformStateV0Methods trait

How Has This Been Tested?

Compile the project

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v1.0.0 milestone Jul 17, 2024
@shumkov shumkov changed the title refactor: don't use private bound for public trait refactor(drive): don't use private bound for public trait Jul 17, 2024
ogabrielides
ogabrielides approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@ogabrielides ogabrielides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov merged commit 811dfa0 into v1.0-dev Jul 17, 2024
24 checks passed
@shumkov shumkov deleted the refactor/drive/private-bound branch July 17, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogabrielides ogabrielides ogabrielides approved these changes

@QuantumExplorer QuantumExplorer Awaiting requested review from QuantumExplorer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@shumkov @ogabrielides