fix(drive): panic if PlatformState has serialisation error #1945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogabrielides
approved these changes
Jul 11, 2024
| pub fn fingerprint(&self) -> [u8; 32] { | ||
| hash_double( | ||
| self.serialize_to_bytes() | ||
| .expect("expected to serialize state"), |
There was a problem hiding this comment.
The reason for the expect is that it can't actually fail. I went into the code to check this.
There was a problem hiding this comment.
We ran into this today on a devnet due to a bug I introduced while testing in PR #1937
There was a problem hiding this comment.
While I don't really mind this PR, can you explain what was introduced?
There was a problem hiding this comment.
We defined PlatformStateForSaving v2 and didn't handle it properly in one of try_from_platform_versioned so we got VersionMismatch error that failed serialisation.
QuantumExplorer
approved these changes
Jul 15, 2024
|
merging this one in without CI check, as it is very simple. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
PlatfromState.fingerprintpanics in case of serialization error.What was done?
expectHow Has This Been Tested?
Running tests
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only