Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(drive-abci)!: rotate quorums when all quorums members have had a chance to propose a block #1942

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

QuantumExplorer
Copy link
Member

@QuantumExplorer QuantumExplorer commented Jul 11, 2024

Issue being fixed or feature implemented

In the past we would rotate every 15 or 25 blocks. This caused later members of a quorum to never be paid. Now instead we rotate when all quorum members have had a chance to propose a block.

What was done?

Got rid of old rotation strategy and introduced a new one. When the last proposer of a quorum proposes we rotate. If that member did not propose a block we rotate as soon as possible.

I noticed some tests were very slow, so I made state saving optional, this reduced the time needed to finish strategy tests by over 50%.

How Has This Been Tested?

Verified that unit tests all passed.

Breaking Changes

This is a breaking change.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov added this to the v1.0.0 milestone Jul 11, 2024
@QuantumExplorer QuantumExplorer merged commit 85920d7 into v1.0-dev Jul 11, 2024
70 checks passed
@QuantumExplorer QuantumExplorer deleted the feat/newQuorumRotation branch July 11, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants