feat(drive-abci)!: rotate quorums when all quorums members have had a chance to propose a block #1942
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
In the past we would rotate every 15 or 25 blocks. This caused later members of a quorum to never be paid. Now instead we rotate when all quorum members have had a chance to propose a block.
What was done?
Got rid of old rotation strategy and introduced a new one. When the last proposer of a quorum proposes we rotate. If that member did not propose a block we rotate as soon as possible.
I noticed some tests were very slow, so I made state saving optional, this reduced the time needed to finish strategy tests by over 50%.
How Has This Been Tested?
Verified that unit tests all passed.
Breaking Changes
This is a breaking change.
Checklist:
For repository code-owners and collaborators only