Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: merkle root hash verification failed on devnet #1929

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Jul 5, 2024

Issue being fixed or feature implemented

DAPI Client failed to sync masternode list on devnet:

warn: [DAPIClient: noid] Can't apply masternode list diff: Merkle root from the diff doesn't match calculated merkle root after diff is applied {
  diffCount: 1,
  network: 'devnet',
  blockHash: '00000063c9614167fac7439247a8177343e4f35e755abda503a717c2d680a610',
  error: Error: Merkle root from the diff doesn't match calculated merkle root after diff is applied
      at SimplifiedMNList.applyDiff (/Users/ivanshumkov/Projects/dashpay/platform/.yarn/cache/@dashevo-dashcore-lib-npm-0.21.1-2fe9b7647d-68502e4078.zip/node_modules/@dashevo/dashcore-lib/lib/deterministicmnlist/SimplifiedMNList.js:86:11)
      at new SimplifiedMNList (/Users/ivanshumkov/Projects/dashpay/platform/.yarn/cache/@dashevo-dashcore-lib-npm-0.21.1-2fe9b7647d-68502e4078.zip/node_modules/@dashevo/dashcore-lib/lib/deterministicmnlist/SimplifiedMNList.js:42:10)
      at ReconnectableStream.dataHandler (/Users/ivanshumkov/Projects/dashpay/platform/packages/js-dapi-client/lib/SimplifiedMasternodeListProvider/SimplifiedMasternodeListProvider.js:137:37)
      at ReconnectableStream.emit (node:events:518:28)
      at ReconnectableStream.dataHandler (/Users/ivanshumkov/Projects/dashpay/platform/packages/js-dapi-client/lib/transport/ReconnectableStream.js:190:10)
      at ClientReadableStreamImpl.emit (node:events:518:28)
      at addChunk (node:internal/streams/readable:559:12)
      at readableAddChunkPushObjectMode (node:internal/streams/readable:536:3)
      at Readable.push (node:internal/streams/readable:391:5)
      at Object.onReceiveMessage (/Users/ivanshumkov/Projects/dashpay/platform/.yarn/cache/@grpc-grpc-js-npm-1.4.4-f333f82239-9d9c1aad22.zip/node_modules/@grpc/grpc-js/build/src/client.js:322:24)

What was done?

  • Fixed deserialisatio of mn entry in dashcore lib

How Has This Been Tested?

Running test suite against devnet

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v1.0.0 milestone Jul 5, 2024
@shumkov shumkov merged commit 58e687f into v1.0-dev Jul 5, 2024
41 checks passed
@shumkov shumkov deleted the fix/merkle-root-verification-on-devnet branch July 5, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants