Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(sdk): regenerate test vectors for masternode voting #1927

Conversation

lklimek
Copy link
Contributor

@lklimek lklimek commented Jul 4, 2024

Issue being fixed or feature implemented

Offline test vectors for tests running in github pipelines are outdated.

What was done?

Regenerated test vectors.

ATM, the following tests fail:

failures:
    fetch::contested_resource::contested_resources_fields::exact_match_query_returns_one_object_plan_656
    fetch::contested_resource::contested_resources_fields::start_at_value_wrong_index_type_returns_invalidargument_plan_653
    fetch::contested_resource::contested_resources_limit_PLAN_656
    fetch::contested_resource_vote_state::contested_resource_vote_states_with_limit_PLAN_674
    fetch::document::document_list_bug_value_text_decode_base58_PLAN_653

fetch::data_contract::test_data_contract_history_read needs separate setup.

Others fail due to open bugs.

How Has This Been Tested?

Run Github Actions https://github.com/dashpay/platform/actions/runs/9808465893

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek marked this pull request as ready for review July 5, 2024 10:53
@QuantumExplorer QuantumExplorer merged commit 372a801 into feat/contestedDocumentResolutionWithMasternodeVoting Jul 5, 2024
82 of 93 checks passed
@QuantumExplorer QuantumExplorer deleted the test/mn-voting-test-vectors branch July 5, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants