Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect proofs are returned for various state transitions #1912

Merged
merged 9 commits into from
Jul 1, 2024
Merged

fix: incorrect proofs are returned for various state transitions #1912

merged 9 commits into from
Jul 1, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Jun 27, 2024 •
edited
Loading

Issue being fixed or feature implemented

RS SDK is not receiving proofs for various quories

What was done?

  • Handled MasternodeVote and Documents with contested resources state transitions
  • Exposed some additional functions in wasm dpp

How Has This Been Tested?

With RS SDK

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Base automatically changed from fix/contestedDocumentResolutionFixes3 to feat/contestedDocumentResolutionWithMasternodeVoting June 28, 2024 10:32
@QuantumExplorer QuantumExplorer marked this pull request as ready for review June 28, 2024 10:34
@QuantumExplorer QuantumExplorer self-requested a review as a code owner June 28, 2024 10:34
@shumkov shumkov changed the title fix: empty proofs are returned for masternode vote state transition fix: incorrect proofs are returned for various state transitions Jun 28, 2024
@lklimek
Copy link
Contributor

lklimek commented Jun 28, 2024

I didn't review but I tested and it fixes the issue.

@shumkov shumkov added this to the v1.0.0 milestone Jul 1, 2024
@shumkov shumkov merged commit 245dc46 into feat/contestedDocumentResolutionWithMasternodeVoting Jul 1, 2024
4 checks passed
@shumkov shumkov deleted the fix/contestedDocumentResolutionFixes4 branch July 1, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lklimek lklimek lklimek approved these changes

@QuantumExplorer QuantumExplorer Awaiting requested review from QuantumExplorer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@shumkov @lklimek @QuantumExplorer