Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cleanup fix and remove identitiesIdsOnly Vote State query #1890

Merged
merged 5 commits into from
Jun 14, 2024
Merged

fix: cleanup fix and remove identitiesIdsOnly Vote State query #1890

merged 5 commits into from
Jun 14, 2024

Conversation

QuantumExplorer
Copy link
Member

Issue being fixed or feature implemented

There were problems in cleanup that needed fixing

What was done?

Removes IdentityIdsOnly

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

lklimek
lklimek reviewed Jun 14, 2024
View reviewed changes
...ages/rs-drive-abci/src/execution/platform_events/voting/check_for_ended_vote_polls/v0/mod.rs Outdated
{
None
(None, contenders_with_no_votes.into_iter().map(|contender| (TowardsIdentity(contender.identity_id), vec![])).collect())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if contenders_with_no_votes.is_empty() then we return (None,None) because contenders_with_no_votes.into_iter() create empty iterator.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@QuantumExplorer QuantumExplorer changed the title Fix/contested document resolution with masternode voting query fixes fix: cleanup fix and remove identitiesIdsOnly Vote State query Jun 14, 2024
@QuantumExplorer QuantumExplorer merged commit 5f287ac into feat/contestedDocumentResolutionWithMasternodeVoting Jun 14, 2024
1 of 3 checks passed
@QuantumExplorer QuantumExplorer deleted the fix/contestedDocumentResolutionWithMasternodeVotingQueryFixes branch June 14, 2024 10:54
@thephez thephez added the dapi-endpoint DAPI endpoint addition or modification label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lklimek lklimek lklimek approved these changes

@shumkov shumkov Awaiting requested review from shumkov

Assignees
No one assigned
Labels
dapi-endpoint DAPI endpoint addition or modification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QuantumExplorer @lklimek @thephez