Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dpp)!: do not allow dependentSchemas #1888

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Jun 13, 2024

Issue being fixed or feature implemented

dependentSchemas could lead to validation errors and misparsing of document type. We don't support conditions in JSON Schema atm

What was done?

  • Removed dependentSchemas from document meta schema

How Has This Been Tested?

None

Breaking Changes

Previous contracts might become invalid.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v1.0.0 milestone Jun 13, 2024
@QuantumExplorer QuantumExplorer merged commit 9db9328 into v1.0-dev Jul 1, 2024
64 checks passed
@QuantumExplorer QuantumExplorer deleted the chore/remove-dependent-schemas branch July 1, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants