Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract document faker to crate #1887

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Jun 13, 2024

Issue being fixed or feature implemented

DPP shouldn't have any external dependencies since this is a public library that is supposed to be cross-platform and cross-environment.

What was done?

  • Extract document faker to a separate crate

How Has This Been Tested?

With existing tests. Added to CI

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v1.0.0 milestone Jun 13, 2024
fominok
fominok previously approved these changes Jun 19, 2024
@QuantumExplorer QuantumExplorer merged commit 903e4d5 into v1.0-dev Jul 1, 2024
125 of 130 checks passed
@QuantumExplorer QuantumExplorer deleted the refactor/extract-faker-to-crate branch July 1, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants