fix(sdk): panic GrpcContextProvider on async call inside sync code #1870
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Two related issues fixed:
This is caused because we have cyclical dependencies: Sdk uses GrpcContextProvider, and GrpcContextProvider uses Sdk.
Unfortunately, due to the way we initialize GrpcContextProvider, it uses an invalid, not complete copy of Sdk. This issue was introduced in #1838 .
What was done?
Issue 1: Implemented a workaround to safely call async code within sync context. This is done in new
spawn_async
fn that uses oneshot channel to synchronize with async thread.Issue 2: Refactored
GrpcContextProvider
to allow setting sdk without need of&mut
. This allows the use ofArc<>
when referring toGrpcContextProvider
, and helps ensure that it uses correct version of Sdk.How Has This Been Tested?
GHA
Run dash-sdk tests against local network.
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only