Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction - Displaying a wrong transaction do not warn us #55

Open
Alex-Werner opened this issue Nov 4, 2019 · 0 comments
Open

Transaction - Displaying a wrong transaction do not warn us #55

Alex-Werner opened this issue Nov 4, 2019 · 0 comments

Comments

@Alex-Werner
Copy link

If we decide to look up for a random non-existant transaction (/insight/tx/0000000001219cb882504216cb0b89de6567483e7a6a3bce45026b26fca9ff17 for instance), we do not have anything warning us about it.

We are only left with this :
image

There is a flashMessage that is being triggered in the Transaction.get method that seems to not be displayed.
Which seems to be linked to the logic being broken, it appears that many method such as Transaction.get(), expect failureCallback to be called on exception such as a status page being 404.
What really happens is that it goes into the successCallback that do not expect thoses and fails.

Some investigation is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant