Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XKeyID (WalletID, AccountID) should be a property of the XKey #40

Open
coolaj86 opened this issue Nov 14, 2024 · 0 comments
Open

XKeyID (WalletID, AccountID) should be a property of the XKey #40

coolaj86 opened this issue Nov 14, 2024 · 0 comments

Comments

@coolaj86
Copy link
Member

While creating the CoinJoin wallet I'm finding that I often have to pass in both walletKey and walletId, or accountKey and accountId, etc in order to cache the key to prevent generating it - since CoinJoin walks the usage rather than the index, and thousands of keys need to be generated quickly.

This creates the opportunity to accidentally pass in a wrong string or otherwise have bad management tracking the two variables.

Instead, we should generate the ID when we generate the XKey, and make it available as a property of the key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant