Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

fix: ProRegTx is not confirm #69

Merged
merged 1 commit into from
Jun 11, 2020
Merged

fix: ProRegTx is not confirm #69

merged 1 commit into from
Jun 11, 2020

Conversation

shuplenkov
Copy link
Member

Issue being fixed or feature implemented

Masternode list was empty after successful masternode registration

What was done?

Wait for 1 confirmation after ProRegTx broadcasted.

How Has This Been Tested?

Manually

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shuplenkov shuplenkov added this to the v0.13 milestone Jun 11, 2020
Copy link
Contributor

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI - you can see the minimum conf requirements for the various networks in the nMasternodeMinimumConfirmations setting in Core (e.g. here for testnet). Looks like all networks other than mainnet use 1.

@shumkov shumkov changed the title fix: wait for 1 confirmation for ProRegTx fix: ProRegTx is not confirm Jun 11, 2020
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👍

@shumkov shumkov merged commit 63a0b9c into v0.13-dev Jun 11, 2020
@shumkov shumkov deleted the fix-register branch June 11, 2020 16:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants