Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

feat: build docker images from local directories #59

Merged
merged 8 commits into from
Jun 9, 2020

Conversation

shuplenkov
Copy link
Member

@shuplenkov shuplenkov commented Jun 5, 2020

Issue being fixed or feature implemented

To improve local testing speed we need to have the ability to specify a local folder with source code of dapi or drive to build the images locally

What was done?

Added docker-compose configs, improved mn start script.

How Has This Been Tested?

Manually by starting masternode with different options sets.

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • Asked @thephez to update corresponding documentation :)

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shuplenkov shuplenkov added this to the v0.13 milestone Jun 5, 2020
@shuplenkov shuplenkov requested a review from shumkov June 5, 2020 15:17
src/commands/start.js Outdated Show resolved Hide resolved
src/commands/start.js Outdated Show resolved Hide resolved
src/commands/start.js Outdated Show resolved Hide resolved
src/docker/DockerCompose.js Outdated Show resolved Hide resolved
@shumkov shumkov changed the title feat: ability to specify docker build path for local development feat: build docker images from local directories Jun 5, 2020
@shumkov
Copy link
Member

shumkov commented Jun 5, 2020

@shuplenkov maybe it will be safer to keep it for v0.14?

src/commands/start.js Outdated Show resolved Hide resolved
@shuplenkov shuplenkov changed the base branch from v0.13-dev to v0.14-dev June 8, 2020 16:57
@shumkov shumkov modified the milestones: v0.13, v0.14 Jun 8, 2020
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 👍

@shuplenkov shuplenkov merged commit 8a3de1f into v0.14-dev Jun 9, 2020
@shuplenkov shuplenkov deleted the docker-local-images branch June 9, 2020 09:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants