This repository has been archived by the owner on Dec 16, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
feat: build docker images from local directories #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shumkov
reviewed
Jun 5, 2020
shumkov
reviewed
Jun 5, 2020
shumkov
suggested changes
Jun 5, 2020
shumkov
changed the title
feat: ability to specify docker build path for local development
feat: build docker images from local directories
Jun 5, 2020
@shuplenkov maybe it will be safer to keep it for v0.14? |
shumkov
reviewed
Jun 8, 2020
… dapi-image-build-path
shumkov
reviewed
Jun 8, 2020
shumkov
reviewed
Jun 8, 2020
… dapi-image-build-path
shumkov
approved these changes
Jun 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 👍
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
To improve local testing speed we need to have the ability to specify a local folder with source code of dapi or drive to build the images locally
What was done?
Added docker-compose configs, improved mn start script.
How Has This Been Tested?
Manually by starting masternode with different options sets.
Breaking Changes
Checklist:
For repository code-owners and collaborators only