This repository has been archived by the owner on Dec 16, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
shumkov
reviewed
May 19, 2020
shumkov
reviewed
May 19, 2020
shumkov
reviewed
May 19, 2020
shumkov
reviewed
May 28, 2020
shumkov
reviewed
May 28, 2020
shumkov
reviewed
Jun 3, 2020
shumkov
changed the title
feat: implement status command
[WIP] feat: implement status command
Jun 8, 2020
shumkov
suggested changes
Jun 13, 2020
shumkov
previously approved these changes
Jun 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
shumkov
changed the title
[WIP] feat: implement status command
feat: implement status command
Jun 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The status command currently outputs some information about the host and docker container states.
I'm unsure about how to properly output this data or if we can share some of the functionality between the
isServiceRunning
andlistContainerStatus
functions. I'd also like to add functionality to output some masternode status by getting various information from inside the containers, and split it up intomn status host
,mn status docker
,mn status masternode
andmn status all
commands, but thought I would check my progress so far first to make sure I'm going about this the right way.