This repository has been archived by the owner on Dec 16, 2021. It is now read-only.
fix: block database contains a block from the future #448
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Dashmate local networks were failing after running for a longer period of time and/or with very short block times (e.g. 10sec on a 4th gen. i7, or 20sec in CI). #430 is also possibly related, and restarting the host without stopping dashmate first may also trigger the bug according to some reports. Core logs generally showed something similar to this:
What was done?
The mocktime feature would simulate 2.5 minute blocks to ensure quorum requests still worked normally. When stopping and then restarting the network, the mocktime would not be set when scanning the block database, causing an error. This PR stores the blocktime to config on shutdown for local networks, and applies the mocktime (if present) to the config file on startup.
How Has This Been Tested?
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only