Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

fix: drive log files were missing upon setup #428

Merged
merged 4 commits into from
Sep 17, 2021
Merged

fix: drive log files were missing upon setup #428

merged 4 commits into from
Sep 17, 2021

Conversation

jawid-h
Copy link
Contributor

@jawid-h jawid-h commented Sep 17, 2021

Issue being fixed or feature implemented

In some situations Drive log files were missing upon setup of the nodes, this leads to Docker infinitely restarts container.

What was done?

  • implemented touchFile function
  • touching or creating an empty log file on setup

How Has This Been Tested?

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@jawid-h jawid-h added this to the v0.21.0 milestone Sep 17, 2021
shumkov
shumkov suggested changes Sep 17, 2021
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic already exists in startNodeTask and I think it’s better place since the problem won’t be solved if you don’t use setup local. I guess, the thing is that this logic is missed in startGroupNodes which is used in case of local network.

shumkov
shumkov reviewed Sep 17, 2021
View reviewed changes
src/listr/tasks/setup/setupLocalPresetTaskFactory.js Outdated
Comment on lines 142 to 143
const drivePrettyLogFile = path.join(os.tmpdir(), `/drive_pretty_${nodeIndex}.log`);
const driveJsonLogFile = path.join(os.tmpdir(), `/drive_json_${nodeIndex}.log`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove slash

shumkov
shumkov approved these changes Sep 17, 2021
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope it works :)

@shumkov shumkov merged commit a1a5298 into v0.21-dev Sep 17, 2021
@shumkov shumkov deleted the fix/drive-log-files branch September 17, 2021 14:01
@shumkov shumkov mentioned this pull request Sep 24, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shumkov shumkov shumkov approved these changes

@strophy strophy Awaiting requested review from strophy

Assignees
No one assigned
Labels
None yet
Milestone
v0.21.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jawid-h @shumkov