Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

feat: tenderdash empty blocks configuration #315

Merged
merged 2 commits into from
Apr 5, 2021
Merged

feat: tenderdash empty blocks configuration #315

merged 2 commits into from
Apr 5, 2021

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Apr 5, 2021

Issue being fixed or feature implemented

For different environments, we need different empty block interval

What was done?

  • Made tenderdash empty blocks configurable with mn bootstrap config

How Has This Been Tested?

  • Running commands

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov requested review from strophy and jawid-h April 5, 2021 10:09
strophy
strophy previously approved these changes Apr 5, 2021
View reviewed changes
Copy link
Contributor

@strophy strophy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

shuplenkov
shuplenkov approved these changes Apr 5, 2021
View reviewed changes
Copy link
Member

@shuplenkov shuplenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@shumkov shumkov added this to the v0.19 milestone Apr 5, 2021
@shumkov shumkov merged commit 1270143 into v0.19-dev Apr 5, 2021
@shumkov shumkov deleted the emoty-blocks branch April 5, 2021 11:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shuplenkov shuplenkov shuplenkov approved these changes

@strophy strophy strophy left review comments

@jawid-h jawid-h Awaiting requested review from jawid-h

Assignees
No one assigned
Labels
None yet
Milestone
v0.19
Development

Successfully merging this pull request may close these issues.
3 participants
@shumkov @shuplenkov @strophy