Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

feat: masternode registration scripts #30

Merged
merged 27 commits into from
Apr 29, 2020
Merged

feat: masternode registration scripts #30

merged 27 commits into from
Apr 29, 2020

Conversation

shuplenkov
Copy link
Member

No description provided.

shumkov
shumkov suggested changes Apr 21, 2020
View reviewed changes
bin/run Outdated
@@ -0,0 +1,6 @@
#!/usr/bin/env node
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bin/mn?

lib/commands/getNewAddress.js Outdated
const path = require('path');
const RpcClient = require('@dashevo/dashd-rpc/promise');
const compose = require('docker-compose');
const waitForCoreStart = require('../util/waitForCoreStart');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These things doesn’t looks like utils, more like business logic. Let’s put core stuff to lib/core/?

package.json Outdated
@@ -0,0 +1,82 @@
{
"name": "mn-bootstrap",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dashevo/mn-bootstrap

shumkov
shumkov reviewed Apr 22, 2020
View reviewed changes
src/commands/wallet/get-new-address.js Outdated
options: [
'evonet',
'local',
'testnet',
Copy link
Member

@shumkov shumkov Apr 22, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it work?

shumkov
shumkov reviewed Apr 22, 2020
View reviewed changes
src/commands/wallet/get-new-address.js Outdated
const { Command, flags: flagTypes } = require('@oclif/command');
const getNewAddress = require('../../../lib/commands/getNewAddress');

class GetNewAddressCommand extends Command {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mn core generate-to-address <amount> --address . Create a new wallet if address omitted

shumkov
shumkov reviewed Apr 22, 2020
View reviewed changes
lib/commands/getNewAddress.js Outdated
@@ -0,0 +1,91 @@
const path = require('path');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/core/wallet

shumkov
shumkov reviewed Apr 22, 2020
View reviewed changes
lib/commands/getNewAddress.js Outdated
if (preset !== 'local') {
console.info('You need to wait at least 100 block before registering masternode');
}
} catch (e) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we shouldn't use console in business logic. we need to handle errors in commands. use oclif error handling

shumkov
shumkov reviewed Apr 22, 2020
View reviewed changes
lib/commands/registerMasternode.js Outdated
@@ -0,0 +1,160 @@
const path = require('path');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/core/mn/

shumkov
shumkov reviewed Apr 22, 2020
View reviewed changes
lib/commands/registerMasternode.js Outdated
addresses: [fundSourceAddress],
});

console.info(`Fund balance is ${balance / SATOSHI_MULTIPLIER}`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

factory should accept logger

shumkov
shumkov reviewed Apr 22, 2020
View reviewed changes
lib/commands/registerMasternode.js Outdated
console.info(`Fund balance is ${balance / SATOSHI_MULTIPLIER}`);

if (balance / SATOSHI_MULTIPLIER < MASTERNODE_DASH_AMOUNT) {
console.error('Needs wallet with more than 1000 dash');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

throw exception

shumkov
shumkov reviewed Apr 22, 2020
View reviewed changes
lib/commands/registerMasternode.js Outdated

console.info(`Masternode registered with tx ${protx}`);
console.info(`Add this bls private key to your config: ${operator.privateKey}`);
} catch (e) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

shumkov
shumkov reviewed Apr 22, 2020
View reviewed changes
lib/commands/registerMasternode.js Outdated
} finally {
// close dash core
await compose.stopOne('core', composeOptions);
await compose.rm(composeOptions);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not flag rm?

shumkov
shumkov reviewed Apr 22, 2020
View reviewed changes
lib/docker-compose.yml Outdated
@@ -0,0 +1,19 @@
version: '3.7'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's existing one with options

shumkov
shumkov reviewed Apr 22, 2020
View reviewed changes
lib/util/generateLocalBlocks.js Outdated
@@ -0,0 +1,20 @@
const { PrivateKey } = require('@dashevo/dashcore-lib');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/core/

shumkov
shumkov reviewed Apr 22, 2020
View reviewed changes
lib/util/getInputsForAmount.js Outdated
@@ -0,0 +1,30 @@
/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/core/wallet/

shumkov
shumkov reviewed Apr 22, 2020
View reviewed changes
lib/util/waitForConfirmations.js Outdated
@@ -0,0 +1,32 @@
const wait = require('./wait');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/src/core/

shumkov
shumkov reviewed Apr 22, 2020
View reviewed changes
lib/util/waitForCoreStart.js Outdated
@@ -0,0 +1,34 @@
const wait = require('./wait');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/core/

shumkov
shumkov reviewed Apr 22, 2020
View reviewed changes
lib/util/waitForCoreStart.js Outdated
do {
try {
// just any random request
await coreClient.getBlockchainInfo();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping?

shumkov
shumkov reviewed Apr 22, 2020
View reviewed changes
lib/util/waitForCoreSync.js Outdated
@@ -0,0 +1,21 @@
const wait = require('./wait');
Copy link
Member

@shumkov shumkov Apr 22, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/core/

shumkov
shumkov reviewed Apr 22, 2020
View reviewed changes
package.json Outdated
@@ -0,0 +1,82 @@
{
"name": "mn-bootstrap",
"version": "0.12.0-dev.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.13.0-dev.1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be a tool for 0.12.x though?

Copy link
Member

@shumkov shumkov Apr 23, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.12 is released and considering as stable (master branch) so just fixes should go there but new untested features should go to dev branch.

shumkov
shumkov reviewed Apr 22, 2020
View reviewed changes
package.json Outdated
{
"name": "mn-bootstrap",
"version": "0.12.0-dev.1",
"description": "Dash masternode bootstrap",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Distribution package for Dash Masternode installation

shumkov
shumkov reviewed Apr 22, 2020
View reviewed changes
lib/commands/getNewAddress.js Outdated

try {
// start dash core
await compose.upOne('core', composeOptions);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use run?

shumkov
shumkov reviewed Apr 22, 2020
View reviewed changes
lib/commands/getNewAddress.js Outdated

if (preset === 'local') {
// generate some blocks to unlock dash
await generateLocalBlocks(coreClient, 100);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's try to use coreClient.generate(100)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this only for use on private devnets? Because it is almost certain to fail on Evonet (it may be possible to generate a few blocks, but not 100 all at once).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's only for the local preset, i.e. regtest

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep 🙈 😄

@cloudwheels cloudwheels mentioned this pull request Apr 25, 2020
Merged
shumkov
shumkov reviewed Apr 28, 2020
View reviewed changes
src/commands/register.js
enabled: () => preset !== PRESETS.LOCAL,
task: async (ctx) => (
new Observable(async (observer) => {
await waitForConfirmations(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we reuse waitForBlocks here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, because your transaction could be included 5 blocks later, for example

shumkov
shumkov reviewed Apr 28, 2020
View reviewed changes
src/commands/register.js Outdated
task: async (ctx) => {
ctx.coreService = await startCore(preset, { wallet: true });

process.on('SIGINT', async () => {
Copy link
Member

@shumkov shumkov Apr 28, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to do that on the exit event, not just Ctrl+C

@shumkov shumkov self-requested a review April 29, 2020 12:38
shumkov
shumkov approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Great work! 🎉

@shuplenkov shuplenkov merged commit 245770e into v0.13-dev Apr 29, 2020
@shuplenkov shuplenkov deleted the masternode branch April 29, 2020 12:42
@cloudwheels cloudwheels mentioned this pull request Apr 29, 2020
Closed
@shumkov shumkov added this to the v0.13 milestone May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thephez thephez thephez left review comments

@shumkov shumkov shumkov approved these changes

@antouhou antouhou Awaiting requested review from antouhou

@jawid-h jawid-h Awaiting requested review from jawid-h

Assignees
No one assigned
Labels
None yet
Milestone
v0.13
Development

Successfully merging this pull request may close these issues.
5 participants
@shuplenkov @shumkov @antouhou @thephez @jawid-h