Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

feat!: configure passFakeAssetLockProofForTests #222

Merged
merged 1 commit into from
Dec 25, 2020
Merged

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Dec 25, 2020

Issue being fixed or feature implemented

With the local network there is no instant lock quorums atm, so we use fallbacks in Drive and need to pass fake instant lock messages.

What was done?

Introduced platform.drive.passFakeAssetLockProofForTests option which is enabled for local config.

How Has This Been Tested?

None

Breaking Changes

platform.drive.passFakeAssetLockProofForTests option is required.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v0.17 milestone Dec 25, 2020
Copy link
Member

@shuplenkov shuplenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@shumkov shumkov merged commit af23a4d into v0.17-dev Dec 25, 2020
@shumkov shumkov deleted the pass-fake branch December 25, 2020 08:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants