This repository has been archived by the owner on Dec 16, 2021. It is now read-only.
feat: expose rawchainlocksig and zmqpubrawtxlocksig from Core
#221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strophy
reviewed
Dec 24, 2020
templates/dashd.conf.template
Outdated
| zmqpubrawchainlocksig=tcp://0.0.0.0:29998 | ||
|
|
||
| {{? it.network === 'testnet'}}testnet=1 | ||
| [test]{{?}} | ||
| {{? it.network === 'local'}} |
There was a problem hiding this comment.
Use elif syntax like {{?? it.network === 'local'}}
jawid-h
previously approved these changes
Dec 25, 2020
shuplenkov
previously approved these changes
Dec 25, 2020
shumkov
changed the title
rawchainlocksig from Corerawchainlocksig and zmqpubrawtxlocksig from Core
shuplenkov
approved these changes
Dec 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Drive requires
rawchainlocksigzmq socket instead ofrawchainlock. DAPI requireszmqpubrawtxlocksigWhat was done?
Expose
rawchainlocksigandzmqpubrawtxlocksigin dashd config instead ofrawchainlockHow Has This Been Tested?
Run setup for local development command
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only