Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

feat: add ZMQ envs for Drive #180

Merged
merged 1 commit into from
Nov 18, 2020
Merged

feat: add ZMQ envs for Drive #180

merged 1 commit into from
Nov 18, 2020

Conversation

shuplenkov
Copy link
Member

Issue being fixed or feature implemented

Drive zmq client needs to have host and port options.

What was done?

Added CORE_ZMQ_HOST and CORE_ZMQ_PORT env variables to docker-compose file.

How Has This Been Tested?

Manually

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shuplenkov shuplenkov added this to the v0.17 milestone Nov 18, 2020
@shumkov shumkov changed the title feat: add zmq enc variables for drive feat: add ZMQ envs for Drive Nov 18, 2020
shumkov
shumkov approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shuplenkov shuplenkov merged commit 32f730d into v0.17-dev Nov 18, 2020
@shuplenkov shuplenkov deleted the drive-zmq-env-vars branch November 18, 2020 16:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shumkov shumkov shumkov approved these changes

@antouhou antouhou Awaiting requested review from antouhou

Assignees
No one assigned
Labels
None yet
Milestone
v0.17
Development

Successfully merging this pull request may close these issues.
2 participants
@shuplenkov @shumkov