Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

fix: services.core.ports contains an invalid type #149

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

strophy
Copy link
Contributor

@strophy strophy commented Sep 8, 2020

Removes quotes from generated .env file, since these are not handled by docker-compose.

Issue being fixed or feature implemented

Trying to start a node with mn config:envs -o .env && docker-compose up fails with various errors as follows:

services.core.ports contains an invalid type, it should be a number, or an object
ERROR: .FileNotFoundError: [Errno 2] No such file or directory: './"docker-compose.yml"'

According to the env file spec:

  • There is no special handling of quotation marks. This means that they are part of the VAL.

What was done?

Remove quotes from generated output.

How Has This Been Tested?

mn config:envs -o .env && docker-compose up
--> no errors, services start as expected

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov changed the base branch from v0.16-dev to master September 8, 2020 09:59
@shumkov shumkov changed the title fix: remove quotes from env file fix: services.core.ports contains an invalid type Sep 8, 2020
@shumkov shumkov added this to the v0.15 milestone Sep 8, 2020
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! 👍

@shumkov shumkov merged commit 5442455 into dashevo:master Sep 8, 2020
@shumkov shumkov deleted the fix-envs-cmd branch September 8, 2020 10:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants