Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

feat: combine image and tag in single field #138

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

strophy
Copy link
Contributor

@strophy strophy commented Aug 30, 2020

Combines image and tag in single field, as requested here.

Issue being fixed or feature implemented

Tags are optional and do not follow any firm convention, making them hard to validate. This commit changes internal handling of tags to align with how Docker does things.

What was done?

  • Merged all image/version fields into single field.

How Has This Been Tested?

  • Tested create config from systemConfigs, get/set values and other commands that trigger config validation
  • Tested start/status/stop/reset commands on testnet and evonet.

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@shumkov shumkov merged commit 35fcf3a into dashevo:v0.15-dev Aug 31, 2020
@shumkov shumkov deleted the docker-tags branch August 31, 2020 09:37
@shumkov shumkov added this to the v0.15 milestone Sep 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants