Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

fix: gRPC buffer size settings in NGINX was too small #127

Merged
merged 1 commit into from
Aug 21, 2020
Merged

fix: gRPC buffer size settings in NGINX was too small #127

merged 1 commit into from
Aug 21, 2020

Conversation

jawid-h
Copy link
Contributor

@jawid-h jawid-h commented Aug 21, 2020

Issue being fixed or feature implemented

grpc_pass buffer size setting was to small resulting in upstream sent too big header while reading response header from upstream error

What was done?

Increased buffer size to 128k

How Has This Been Tested?

Local dev env.

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@jawid-h jawid-h added this to the v0.15 milestone Aug 21, 2020
@jawid-h jawid-h requested a review from shumkov August 21, 2020 09:33
shumkov
shumkov approved these changes Aug 21, 2020
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👍

@shumkov shumkov merged commit 55b0acf into v0.15-dev Aug 21, 2020
@shumkov shumkov deleted the fix/buffer-size branch August 21, 2020 10:26
@shuplenkov shuplenkov self-requested a review August 28, 2020 09:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shumkov shumkov shumkov approved these changes

@shuplenkov shuplenkov Awaiting requested review from shuplenkov

Assignees
No one assigned
Labels
None yet
Milestone
v0.15
Development

Successfully merging this pull request may close these issues.
2 participants
@jawid-h @shumkov