Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How are the autocompleted options for a component chosen? #162

Open
aabmass opened this issue Nov 1, 2023 · 2 comments
Open

How are the autocompleted options for a component chosen? #162

aabmass opened this issue Nov 1, 2023 · 2 comments

Comments

@aabmass
Copy link

aabmass commented Nov 1, 2023

First off thanks for working on this, it's pretty cool.

I'm wondering how the autocompleted options for a component are chosen. When I type googlecloud<TAB> in the exporters section, it automatically adds the following config keys:

  googlecloud:
    project: 
    user_agent: opentelemetry-collector-contrib {{version}}
    destination_project_quota: false
    timeout: "12s"

All but project are not options that users would normally want to tweak. It seems like the defaults come maybe come from the mapconfig default struct tag? I would guess that options with a default are usually the least relevant to users.

@bripkens
Copy link
Member

bripkens commented Nov 2, 2023

Hey @aabmass,

we currently rely on a JSON schema and monaco-yaml to generate the autocompletion.

Agree w.r.t. the behavior. I have opened an issue with monaco-yaml to understand whether there is a way to change this behavior.

@aabmass
Copy link
Author

aabmass commented Nov 2, 2023

Got it, thanks for looking into this!

@bripkens bripkens removed their assignment Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants