Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(xmlupload): serialise resource #1278

Merged
merged 23 commits into from
Nov 18, 2024

Conversation

Nora-Olivia-Ammann
Copy link
Collaborator

No description provided.

@Nora-Olivia-Ammann Nora-Olivia-Ammann self-assigned this Nov 15, 2024
Copy link
Collaborator

@jnussbaum jnussbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. In 1 place, I don't understand the logic, so I made a comment.

@Nora-Olivia-Ammann Nora-Olivia-Ammann merged commit 839bb2e into main Nov 18, 2024
14 checks passed
@Nora-Olivia-Ammann Nora-Olivia-Ammann deleted the wip/xmlupload-refactor-seralise-resource branch November 18, 2024 09:47
@daschbot daschbot mentioned this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants