Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(validate-data): check file value cardinality (DEV-4338) #1264

Merged
merged 39 commits into from
Nov 12, 2024
Merged

feat(validate-data): check file value cardinality (DEV-4338) #1264

merged 39 commits into from
Nov 12, 2024

Conversation

Nora-Olivia-Ammann
Copy link
Collaborator

No description provided.

@Nora-Olivia-Ammann Nora-Olivia-Ammann self-assigned this Nov 11, 2024
@linear Linear
Copy link

linear bot commented Nov 11, 2024

DEV-4338 validate cardinality for file values

@Nora-Olivia-Ammann
add test data
d2edd30
@Nora-Olivia-Ammann
test data
31d2e30
@Nora-Olivia-Ammann
deserialise input
2d9a29b
@Nora-Olivia-Ammann
add file value rdf
dfa3203
@Nora-Olivia-Ammann
Merge branch 'main' into wip/dev-4338-validate-file-value-cardinalities
5207927
@Nora-Olivia-Ammann
change abstract file value
4b46215
@Nora-Olivia-Ammann
Update api-shapes.ttl
ec4f82d
@Nora-Olivia-Ammann
change deserialisation of file value
44ff05b
@Nora-Olivia-Ammann
linting
3505d40
@Nora-Olivia-Ammann
include res id
29e5f0e
@Nora-Olivia-Ammann
make graph
73d7a67
@Nora-Olivia-Ammann
add generic file value
a3ddf79
@Nora-Olivia-Ammann
fix arg order
0fe25a4
@Nora-Olivia-Ammann
Create file_value_shacl.py
b00f425
@Nora-Olivia-Ammann
Update construct_shacl.py
37c94e3
@Nora-Olivia-Ammann
Update file_value_shacl.py
c2a03b1
@Nora-Olivia-Ammann
Update api-shapes.ttl
d51bd49
@Nora-Olivia-Ammann
change serialisation
22262f5
@Nora-Olivia-Ammann
change serialisation
ad417c7
@Nora-Olivia-Ammann
update tests
509671a
@Nora-Olivia-Ammann
Update api-shapes.ttl
a12c01e
@Nora-Olivia-Ammann
Update test_validate_data.py
1e8cc94
@Nora-Olivia-Ammann
test reformatting
55e4cf1
@Nora-Olivia-Ammann
update onto
019c679
@Nora-Olivia-Ammann
Update test_cardinality_shacl.py
fe13bf5
@Nora-Olivia-Ammann
Create test_file_value_shacl.py
529470e
seakayone
seakayone requested changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@seakayone seakayone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, except for the missing DDDRepresentation.

src/dsp_tools/commands/validate_data/sparql/file_value_shacl.py Show resolved Hide resolved
@Nora-Olivia-Ammann
Copy link
Collaborator Author

Looks good to me, except for the missing DDDRepresentation.

Yes it is missing, but I did not add it because it is not implemented in dsp-tools. So currently it is not possible to create one.
I also did not know what extension it would have because it is not listed in the API docs. https://docs.dasch.swiss/latest/DSP-API/01-introduction/file-formats/

Should I add it anyway?

@seakayone
Copy link
Contributor

Yes it is missing, but I did not add it because it is not implemented in dsp-tools.

Should I add it anyway?

I guess in this case we can skip it.

@seakayone seakayone self-requested a review November 12, 2024 09:52
@Nora-Olivia-Ammann Nora-Olivia-Ammann merged commit cefc466 into main Nov 12, 2024
14 checks passed
@Nora-Olivia-Ammann Nora-Olivia-Ammann deleted the wip/dev-4338-validate-file-value-cardinalities branch November 12, 2024 09:54
@daschbot daschbot mentioned this pull request Nov 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seakayone seakayone seakayone approved these changes

Assignees

@Nora-Olivia-Ammann Nora-Olivia-Ammann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nora-Olivia-Ammann @seakayone