Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bazel build tool support #116

Closed
subotic opened this issue Oct 19, 2019 · 4 comments
Closed

Add Bazel build tool support #116

subotic opened this issue Oct 19, 2019 · 4 comments
Assignees
Milestone

Comments

@subotic
Copy link
Contributor

subotic commented Oct 19, 2019

For Angular, adding Bazel should be fairly straightforward: https://angular.io/guide/bazel

@subotic subotic added this to the 2019-10 milestone Oct 19, 2019
@subotic subotic added the build label Oct 19, 2019
@subotic subotic assigned subotic and unassigned flavens Oct 19, 2019
@kilchenmann
Copy link
Contributor

Adding bazel doesn't seem to be quite easy to implement. There are some issues with sass/scss especially with the material theming and with @angular/flex-layout.

I tried to fix it by following these issues:

But ng s or ng build --leaveBazelFilesOnDisk still failing. I got the following errors:

ERROR: knora-app/src/BUILD.bazel:26:1: Compiling Sass failed (Exit 65)
Error: Can't find stylesheet to import.
  ╷
6 │ @import 'external/npm/node_modules/@angular/material/theming';
  │         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  ╵
  src/assets/style/_theme.scss 6:9             @import
  src/app/main/login/login.component.scss 1:9  root stylesheet

Error: Can't find stylesheet to import.
  ╷
1 │ @import 'external/npm/node_modules/@angular/material/theming';
  │         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  ╵
  src/app/project/ontology/ontology.component.scss 1:9  root stylesheet

[...]

I'm working on branch wip/add-bazel

@subotic
Copy link
Contributor Author

subotic commented Oct 24, 2019

Great, thanks. I will take a look. At first glance, this looks like a dependency configuration issue. Bazel is building everything in a sandbox, and if the external dependencies are not configured correctly, then stuff is missing in the sandbox.

@kilchenmann kilchenmann modified the milestones: 2019-10, 2019-11 Oct 28, 2019
@kilchenmann
Copy link
Contributor

All you have to know about bazel:
https://youtu.be/J1lnp-nU4wM
or in the summary:
https://youtu.be/wYUQ0RtN7oc

Btw I will try to implement again after adding knora-api-js-lib

@kilchenmann kilchenmann modified the milestones: 2019-11, 2019-12 Nov 28, 2019
@flavens flavens modified the milestones: 2019-12, 2020-01 Dec 3, 2019
@flavens flavens modified the milestones: 2020-01, 2020-04 Jan 20, 2020
@flavens
Copy link
Contributor

flavens commented May 27, 2020

this issue has been moved to YouTrack: DSP-283

@flavens flavens closed this as completed May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants