Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

h2po4g is unused in approx pCO2 solver #1

Open
briochemc opened this issue Jun 28, 2022 · 0 comments
Open

h2po4g is unused in approx pCO2 solver #1

briochemc opened this issue Jun 28, 2022 · 0 comments

Comments

@briochemc
Copy link

I noticed that h2po4g is unused (thank you VScode + linter!):

h2po4g = (pt*k1plocal*hguess*hguess) / stuff

I guess this line can be safely removed then. Not sure this is of any use, but I thought I'd point it out in case it is! :)

FWIW I stumbled on this while trying to translate this pCO2 solver from Follows et al., to MATLAB 😭 (to get away from Newton-solver issues in CO2sys.m).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant