Skip to content
This repository has been archived by the owner on Oct 9, 2022. It is now read-only.

Correct the proposal API #69

Merged
merged 17 commits into from
Sep 3, 2020
Merged

Correct the proposal API #69

merged 17 commits into from
Sep 3, 2020

Conversation

clearloop
Copy link
Collaborator

@clearloop clearloop commented Sep 1, 2020 •
edited
Loading

Desc

  • Correct the mmr_root order in proposal response
  • Add logs for generating mmr roots
  • Get back eth/proof api for guard system
  • More test of proposal API

@clearloop clearloop marked this pull request as ready for review September 2, 2020 04:31
hackfisher
hackfisher suggested changes Sep 2, 2020
View reviewed changes
src/api/eth/proposal.rs Outdated Show resolved Hide resolved
@clearloop clearloop mentioned this pull request Sep 2, 2020
Merged
6 tasks
@clearloop clearloop added the A3-inprogress Pull request is in progress. No review needed at this stage. label Sep 2, 2020
clearloop
clearloop commented Sep 2, 2020
View reviewed changes
src/api/eth/proposal.rs Outdated Show resolved Hide resolved
@clearloop clearloop added A0-pleasereview Pull request needs code review. and removed A3-inprogress Pull request is in progress. No review needed at this stage. labels Sep 2, 2020
@clearloop clearloop mentioned this pull request Sep 2, 2020
Merged
2 tasks
@hackfisher hackfisher merged commit 040ecda into next Sep 3, 2020
@hackfisher hackfisher deleted the api branch September 3, 2020 03:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hackfisher hackfisher hackfisher approved these changes

Assignees
No one assigned
Labels
A0-pleasereview Pull request needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clearloop @hackfisher