Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish external library files from DART code base #787

Merged
merged 8 commits into from
Oct 13, 2016

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Oct 10, 2016

Motivation

DART contains several external code files, and they are placed in the DART directories without distinction. It would be good to separate those external from the DART code base for better maintenance.

Changes

  • Move external code files to separate directory (e.g., dart/external/THE_LIBRARY_NAME). The being extracted files are ImGui, lodepng, and ODE (the LCP solver part).
  • Build them as separate targets and components
  • Link to the targets if needed

Note

  • Export each CMake component/target as a separate file #786 should be merged before this PR. Actual changes of this PR
  • The targets are intentionally exposed to projects that depend on DART because they may want to use the targets. For example, osgAtlasSimbicon example uses ImGui through DART.
  • One positive side effect of this change is that the code coverage measure would be a little more accurate since we don't check the external code files.
  • The headers of the external code files are no longer listed in the directory headers (e.g., dart/dart.hpp and dart/dynamics/dynamics.hpp). We could add them when we find it's needed.

This change is Reviewable

External sources:
- ImGui
- lodepng
- ODE (part of LCP solver)
@jslee02 jslee02 added this to the DART 6.1.1 milestone Oct 10, 2016
@jslee02 jslee02 changed the base branch from master to release-6.1 October 10, 2016 22:40
@jslee02 jslee02 changed the title Distinguish external library from DART code base Distinguish external library files from DART code base Oct 10, 2016
@jslee02 jslee02 merged commit 8e19a4d into release-6.1 Oct 13, 2016
@jslee02 jslee02 deleted the external_libraries branch October 13, 2016 20:38
@jslee02 jslee02 restored the external_libraries branch October 14, 2016 19:19
@jslee02 jslee02 deleted the external_libraries branch October 15, 2016 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant