Add cmake option DART_MSVC_DEFAULT_OPTIONS for Visual Studio build #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for AppVeyor to be happy before merging. |
jslee02
added a commit
that referenced
this pull request
Nov 6, 2015
Add cmake option DART_MSVC_DEFAULT_OPTIONS for Visual Studio build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have optimized build options of Visual Studio to find best ones for DART. However, the customized options seems to increase the build time so that it can not pass AppVeyor build tests: every build should be done within 1 hour, which is allowed to a testing project.
This pull request adds an cmake option that builds DART with reduced version of custom options so that the build time is reduced. This option is only turned on for AppVeyor tests, and, by default, this option is set to off so the default behavior wouldn't be changed from the previous.