Fix compilation errors and warnings on Windows #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The macros was required since old Visual Studio does not support those functions; they have similar implementation in Visual Studio but they are not in std namespace and have slightly different names - Visual Studio 2013 and after support those functions and now these macros cause compilation errors because of the namespace issue. For example, std::nextafter(~) will be modified by the macro to std::_nextafter(~) but _nextafter(~) is not in std namespace.
jslee02
added a commit
that referenced
this pull request
Oct 11, 2015
Fix compilation errors and warnings on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
) will be modified by the macro to std::_nextafter() but _nextafter(~) is not in std namespace.Note that AppVeyor CI build test wouldn't pass since #488 has not addressed yet.