Initialize mRestPosition if zero is not in range. #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suppose this is alright. I wouldn't normally assume that the rest position should be the same as the initial position, but since we don't have a way of reading a rest position from SDF or URDF, we may as well make the assumption for lack of a better alternative. 👍 |
|
👍 |
jslee02
added a commit
that referenced
this pull request
Aug 9, 2015
Initialize mRestPosition if zero is not in range.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the bug that I fixed in #438. This was intended to be fixed with the addition of
mInitialPositionsin #449. However, that pull request only setsmInitialPositions, notmRestPositions, in the URDF and SDF loaders.This pull request restores the same logic to
mRestPositions.