Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to Linkage and Chain Criteria #443

Merged
merged 6 commits into from
Jul 13, 2015
Merged

Changes to Linkage and Chain Criteria #443

merged 6 commits into from
Jul 13, 2015

Conversation

mxgrey
Copy link
Member

@mxgrey mxgrey commented Jul 8, 2015

This pull request addresses issue #437 and replaces pull request #440.

The changes are as follows:

  • You can now tell specify in your Linkage Criteria that a start or a target BodyNode should be excluded from the Linkage.
  • The new default behavior for Chains is that whichever BodyNode is upstream of the other will be excluded from the Chain
  • An alternative constructor is available for Chains which allows the user to request that both the start and the target BodyNodes should be included, regardless of which is upstream
  • Linkage and Chain criteria now allow you to specify a nullptr starting BodyNode, which will be treated as if it represents the World

@mkoval
Copy link
Collaborator

mkoval commented Jul 8, 2015

It looks like the Travis build failed with an obscure Boost error:

[ 37%] Building CXX object dart/CMakeFiles/dart-core.dir/collision/fcl/FCLCollisionNode.cpp.o
In file included from /usr/local/include/boost/numeric/conversion/numeric_cast_traits.hpp:28:0,
                 from /usr/local/include/boost/numeric/conversion/cast.hpp:34,
                 from /usr/local/include/boost/lexical_cast.hpp:159,
                 from /usr/local/include/boost/math/constants/constants.hpp:18,
                 from /usr/include/fcl/BV/RSS.h:43,
                 from /usr/include/fcl/ccd/motion_base.h:45,
                 from /usr/include/fcl/collision_object.h:43,
                 from /usr/include/fcl/collision.h:42,
                 from /home/travis/build/dartsim/dart/dart/collision/fcl/FCLCollisionNode.h:44,
                 from /home/travis/build/dartsim/dart/dart/collision/fcl/FCLCollisionNode.cpp:37:
/usr/local/include/boost/numeric/conversion/detail/numeric_cast_traits.hpp:12:91: fatal error: boost/numeric/conversion/detail/preprocessed/numeric_cast_traits_common.hpp: No such file or directory
     #include <boost/numeric/conversion/detail/preprocessed/numeric_cast_traits_common.hpp>

You didn't change anything in that file, so I don't know what the cause is.

@mxgrey
Copy link
Member Author

mxgrey commented Jul 8, 2015

It's a nonsense issue that Travis spits out occasionally, possibly because of incorrect installation of boost. It just needs to be rerun.

@jslee02 jslee02 added this to the DART 5.1.0 milestone Jul 13, 2015
@jslee02
Copy link
Member

jslee02 commented Jul 13, 2015

👍

jslee02 added a commit that referenced this pull request Jul 13, 2015
Changes to Linkage and Chain Criteria
@jslee02 jslee02 merged commit 3dcc8ba into master Jul 13, 2015
@jslee02 jslee02 deleted the grey/exclusive_chain branch August 14, 2015 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants