Fix imgui is not properly set when DART_USE_SYSTEM_IMGUI=ON #1877
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to prevent the downstream packages need to manually add
find_package(imgui)
, which is not ideal.The generated
dart_gui-osgComponent.cmake
should contain bothimgui
andOpenSceneGraph
.Before:
After:
I also changed the error to a warning for building with old OSG (< 3.7.0) on macOS to allow building with the old version but with a patch for the issue.
Before creating a pull request
make format
-DDART_TREAT_WARNINGS_AS_ERRORS=ON
and resolve all the compile warningsBefore merging a pull request
CHANGELOG.md