Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed invalid array access in moving skeleton subtree #1778

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Fixed invalid array access in moving skeleton subtree #1778

merged 1 commit into from
Dec 19, 2023

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Dec 19, 2023 •
edited
Loading

Tested on 7.0 (main) with -D_GLIBCXX_ASSERTIONS: https://github.com/dartsim/dart/actions/runs/7258388815/job/19773633871

Resolve #1769

Before creating a pull request

  • Document new methods and classes
  • Format new code files using ClangFormat by running make format
  • Build with -DDART_TREAT_WARNINGS_AS_ERRORS=ON and resolve all the compile warnings

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change
  • Add Python bindings for new methods and classes

@jslee02 jslee02 marked this pull request as ready for review December 19, 2023 07:41
@jslee02 jslee02 merged commit b7f5dd1 into release-6.13 Dec 19, 2023
0 of 2 checks passed
@jslee02 jslee02 deleted the 6.13/fix_issue1445 branch December 19, 2023 14:31
@jslee02 jslee02 mentioned this pull request Dec 19, 2023
Closed
@jslee02 jslee02 added this to the DART 6.13.1 milestone Jan 5, 2024
@jslee02 jslee02 changed the title Attempt to fix #1769 Fixed invalid array access in moving skeleton subtree Jan 5, 2024
@BrewTestBot BrewTestBot mentioned this pull request Jan 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
DART 6.13.1
Development

Successfully merging this pull request may close these issues.

[Issue1445.Collision] Regression test crashes
1 participant
@jslee02