Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of boost::filesystem and boost::optional #1648

Merged
merged 5 commits into from
Jan 15, 2022
Merged

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Jan 14, 2022


Before creating a pull request

  • Document new methods and classes
  • Format new code files using ClangFormat by running make format
  • Build with -DDART_TREAT_WARNINGS_AS_ERRORS=ON and resolve all the compile warnings

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change
  • Add Python bindings for new methods and classes

@jslee02 jslee02 added this to the DART 6.13.0 milestone Jan 14, 2022
@jslee02 jslee02 force-pushed the nuke_boost branch 2 times, most recently from 03b96b1 to aa07c82 Compare January 14, 2022 20:49
@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #1648 (292938d) into main (2a158b1) will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##             main    #1648   +/-   ##
=======================================
  Coverage   59.13%   59.13%           
=======================================
  Files         497      497           
  Lines       40881    40881           
=======================================
+ Hits        24174    24175    +1     
+ Misses      16707    16706    -1     
Impacted Files Coverage Δ
dart/utils/mjcf/detail/Body.cpp 81.25% <ø> (ø)
dart/utils/mjcf/detail/Body.hpp 100.00% <ø> (ø)
dart/utils/mjcf/detail/BodyAttributes.cpp 67.34% <ø> (ø)
dart/utils/mjcf/detail/Compiler.cpp 47.70% <ø> (ø)
dart/utils/mjcf/detail/Geom.cpp 70.94% <ø> (ø)
dart/utils/mjcf/detail/Inertial.hpp 100.00% <ø> (ø)
dart/utils/mjcf/detail/Site.cpp 41.57% <ø> (ø)
dart/utils/mjcf/detail/Site.hpp 100.00% <ø> (ø)
dart/utils/mjcf/detail/Utils.cpp 61.70% <ø> (ø)
dart/utils/mjcf/detail/Weld.hpp 100.00% <ø> (ø)
... and 7 more

@jslee02 jslee02 marked this pull request as ready for review January 15, 2022 15:02
@jslee02 jslee02 merged commit e914c4d into main Jan 15, 2022
@jslee02 jslee02 deleted the nuke_boost branch January 15, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant