Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MemoryManager and MemoryAllocatorDebugger #1646

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Jan 7, 2022


Before creating a pull request

  • Document new methods and classes
  • Format new code files using ClangFormat by running make format
  • Build with -DDART_TREAT_WARNINGS_AS_ERRORS=ON and resolve all the compile warnings

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change
  • Add Python bindings for new methods and classes

@jslee02 jslee02 added this to the DART 6.13.0 milestone Jan 7, 2022
@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #1646 (96c346d) into main (f07186f) will decrease coverage by 0.00%.
The diff coverage is 72.13%.

@@            Coverage Diff             @@
##             main    #1646      +/-   ##
==========================================
- Coverage   59.12%   59.11%   -0.01%     
==========================================
  Files         494      496       +2     
  Lines       40766    40795      +29     
==========================================
+ Hits        24101    24116      +15     
- Misses      16665    16679      +14     
Impacted Files Coverage Δ
dart/common/CAllocator.hpp 100.00% <ø> (ø)
dart/common/FreeListAllocator.hpp 0.00% <ø> (ø)
dart/common/MemoryAllocator.hpp 100.00% <ø> (ø)
dart/common/PoolAllocator.hpp 0.00% <ø> (ø)
dart/common/StlAllocator.hpp 100.00% <ø> (ø)
dart/constraint/ConstraintSolver.hpp 100.00% <ø> (ø)
dart/dynamics/BodyNode.hpp 100.00% <ø> (ø)
dart/constraint/ConstraintSolver.cpp 67.97% <60.00%> (-0.72%) ⬇️
dart/common/MemoryManager.cpp 62.71% <62.71%> (ø)
...art/common/detail/MemoryAllocatorDebugger-impl.hpp 68.18% <68.18%> (ø)
... and 10 more

@jslee02 jslee02 marked this pull request as ready for review January 7, 2022 20:49
@jslee02 jslee02 merged commit 876567c into main Jan 7, 2022
@jslee02 jslee02 deleted the memory_manager branch January 7, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant