Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MemoryAllocator and CAllocator #1636

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Add MemoryAllocator and CAllocator #1636

merged 1 commit into from
Dec 23, 2021

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Dec 23, 2021

Initial work for adding custom memory allocator:

  • Add MemoryAllocator that is a base class for custom memory allocators
  • Add CAllocator that is a simple wrapper of std::malloc and std::free

Before creating a pull request

  • Document new methods and classes
  • Format new code files using ClangFormat by running make format
  • Build with -DDART_TREAT_WARNINGS_AS_ERRORS=ON and resolve build warnings

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.13.0 milestone Dec 23, 2021
@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #1636 (7a5a8b1) into main (627f71e) will increase coverage by 0.02%.
The diff coverage is 72.09%.

❗ Current head 7a5a8b1 differs from pull request most recent head fc60b2f. Consider uploading reports for the commit fc60b2f to get more accurate results

@@            Coverage Diff             @@
##             main    #1636      +/-   ##
==========================================
+ Coverage   58.93%   58.95%   +0.02%     
==========================================
  Files         477      483       +6     
  Lines       40166    40252      +86     
==========================================
+ Hits        23670    23729      +59     
- Misses      16496    16523      +27     
Impacted Files Coverage Δ
dart/common/CAllocator.hpp 0.00% <0.00%> (ø)
dart/common/MemoryAllocator.cpp 0.00% <0.00%> (ø)
dart/common/CAllocator.cpp 72.09% <72.09%> (ø)
dart/common/MemoryAllocator.hpp 100.00% <100.00%> (ø)
dart/common/detail/Logging-impl.hpp 100.00% <100.00%> (ø)
python/dartpy/common/Logging.cpp 100.00% <100.00%> (ø)
python/dartpy/common/module.cpp 100.00% <100.00%> (ø)
dart/dynamics/Skeleton.cpp 67.74% <0.00%> (-0.17%) ⬇️

@jslee02 jslee02 marked this pull request as ready for review December 23, 2021 21:58
@jslee02 jslee02 merged commit 09935e5 into main Dec 23, 2021
@jslee02 jslee02 deleted the mem_allocator branch December 23, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant