Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Castable class #1634

Merged
merged 2 commits into from
Dec 23, 2021
Merged

Add Castable class #1634

merged 2 commits into from
Dec 23, 2021

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Dec 23, 2021

Add Castable class, a CRTP base class that provides an interface for easily casting to the derived types


Before creating a pull request

  • Document new methods and classes
  • Format new code files using ClangFormat by running make format
  • Build with -DDART_TREAT_WARNINGS_AS_ERRORS=ON and resolve all the compile warnings

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.13.0 milestone Dec 23, 2021
@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #1634 (9ec8a49) into main (3ad6719) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1634      +/-   ##
==========================================
+ Coverage   58.91%   58.93%   +0.01%     
==========================================
  Files         477      477              
  Lines       40192    40166      -26     
==========================================
- Hits        23680    23670      -10     
+ Misses      16512    16496      -16     
Impacted Files Coverage Δ
dart/constraint/BoxedLcpSolver.hpp 100.00% <ø> (ø)
dart/collision/bullet/BulletCollisionDetector.cpp 69.97% <100.00%> (+0.85%) ⬆️
dart/collision/ode/OdeCollisionObject.cpp 77.50% <100.00%> (-0.91%) ⬇️
dart/common/detail/Castable-impl.hpp 100.00% <100.00%> (ø)
dart/dynamics/EulerJoint.cpp 73.09% <0.00%> (+2.92%) ⬆️

@jslee02 jslee02 marked this pull request as ready for review December 23, 2021 16:31
@jslee02 jslee02 merged commit 627f71e into main Dec 23, 2021
@jslee02 jslee02 deleted the castable branch December 23, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant