Fix incorrect MultiSphereConvexHull rendering #1579
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
MultiSphereConvexHull
was rendered as a composition of spheres and cylinders (that connect the spheres) rather than the actual convex hull. To fix the issue, this PR addsMesh
,TriMesh
, andIcosphere
classes, where they provide a feature of convex hull generation. The GLUT and OSG rendereres now draw a convex hull forMultiSphereConvexHull
by (1) generating icosphere meshes from the spheres, (2) merge then as a single triangle mesh, and (3) lastly generating a convex hull out of the merged triangle mesh.Also, this PR is a preliminary work to address #453.
Old:
New:
Before creating a pull request
clang-format
Before merging a pull request
CHANGELOG.md