Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect MultiSphereConvexHull rendering #1579

Merged
merged 1 commit into from
May 3, 2021
Merged

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented May 3, 2021

Previously, MultiSphereConvexHull was rendered as a composition of spheres and cylinders (that connect the spheres) rather than the actual convex hull. To fix the issue, this PR adds Mesh, TriMesh, and Icosphere classes, where they provide a feature of convex hull generation. The GLUT and OSG rendereres now draw a convex hull for MultiSphereConvexHull by (1) generating icosphere meshes from the spheres, (2) merge then as a single triangle mesh, and (3) lastly generating a convex hull out of the merged triangle mesh.

Also, this PR is a preliminary work to address #453.

Old:
Screenshot from 2021-05-03 02-02-53

New:
Screenshot from 2021-05-03 02-01-52


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 marked this pull request as ready for review May 3, 2021 16:20
@jslee02 jslee02 merged commit 3fbc45d into release-6.11 May 3, 2021
@jslee02 jslee02 deleted the convex_hull branch May 3, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant