Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python bindings for adding ShapeFrames to CollisionGroup #1490

Merged
merged 2 commits into from
Aug 28, 2020

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Aug 28, 2020

This PR adds the following Python bindings for

  • dart::collision::CollisionGroup::addShapeFramesOf(...)
  • dart::collision::ShapeFrame::removeShapeFramesOf(...)
  • group-group collision checking
  • dart::gui::osg::Viewer::frame()

Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.10.0 milestone Aug 28, 2020
@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

Merging #1490 into master will decrease coverage by 0.02%.
The diff coverage is 11.11%.

@@            Coverage Diff             @@
##           master    #1490      +/-   ##
==========================================
- Coverage   58.20%   58.18%   -0.03%     
==========================================
  Files         412      414       +2     
  Lines       29913    30008      +95     
==========================================
+ Hits        17412    17459      +47     
- Misses      12501    12549      +48     
Impacted Files Coverage Δ
dart/collision/CollisionResult.cpp 70.73% <0.00%> (ø)
dart/constraint/BoxedLcpConstraintSolver.cpp 53.00% <0.00%> (ø)
dart/dynamics/PyramidShape.hpp 0.00% <0.00%> (ø)
dart/dynamics/Skeleton.hpp 83.33% <ø> (ø)
dart/collision/fcl/FCLCollisionDetector.cpp 85.62% <2.85%> (-4.01%) ⬇️
dart/dynamics/PyramidShape.cpp 6.25% <6.25%> (ø)
dart/utils/SkelParser.cpp 66.66% <14.28%> (-0.39%) ⬇️
dart/dynamics/Skeleton.cpp 66.39% <100.00%> (+0.22%) ⬆️
dart/dynamics/detail/GenericJoint.hpp 75.47% <100.00%> (+0.03%) ⬆️
... and 7 more

@jslee02 jslee02 marked this pull request as ready for review August 28, 2020 01:25
@jslee02 jslee02 merged commit 88dfe70 into master Aug 28, 2020
@jslee02 jslee02 deleted the python_coverage branch August 28, 2020 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant