Update signal to remove a connection when disconnected #1462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
Signal
design doesn't clean up disconnected connections until the signal calls the registered slots:dart/dart/common/detail/Signal.hpp
Lines 120 to 141 in 3f76766
or
cleanupConnection()
is explicitly called. This could lead to large memory consumption if we make many connections and disconnect them before emitting the signal or don't usecleanupConnection()
in a right time.This PR
Signal
to remove the disconnected connections when it's disconnected. This change keeps the backward compatibility because none of the public API isn't being changed.Before creating a pull request
clang-format
Before merging a pull request
CHANGELOG.md