Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dartpy] Add wrapper for convertToPositions() in class BallJoint #1408

Merged

Conversation

chhinze
Copy link
Contributor

@chhinze chhinze commented Aug 27, 2019

Expose dartpy.dynamics.BallJoint.convertToPositions() to dartpy.


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.10.0 milestone Aug 28, 2019
@codecov
Copy link

codecov bot commented Aug 28, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@9ea802b). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1408   +/-   ##
=========================================
  Coverage          ?   57.28%           
=========================================
  Files             ?      366           
  Lines             ?    27483           
  Branches          ?        0           
=========================================
  Hits              ?    15743           
  Misses            ?    11740           
  Partials          ?        0

jslee02
jslee02 previously approved these changes Aug 28, 2019
Copy link
Member

@jslee02 jslee02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution!

@chhinze
Copy link
Contributor Author

chhinze commented Aug 28, 2019

Thank you for merging it.

@jslee02 jslee02 merged commit 8cf7f5c into dartsim:master Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants